fix: Correct response model for create entitlement#92
Merged
cb-alish merged 1 commit intochargebee:masterfrom Oct 10, 2025
Merged
Conversation
Updated the response model for create entitlement route. Also added logic to conditionally set result params in parse_list_response.
Contributor
Author
|
Hey guys, just checking in. Have you guys gotten a chance to look at this PR? |
|
Hey, we are also facing this issue, and this MR seems to be fixing it. |
|
hey @cb-sriramthiagarajan , Please have a look, we are facing issues,this MR fixed it |
Collaborator
|
Hi @abhinav2712 @overide @kurayami07734, thank you for raising this. We're looking into this and will get back soon. |
cb-alish
approved these changes
Oct 10, 2025
Collaborator
|
Hi @kurayami07734, thanks a lot for taking the time to raise this PR. We've included the changes in our latest release (#100). The field |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the response model for create entitlement route. Also added logic to conditionally set result params in parse_list_response.
Description
Fixes failure when entitlements are being created using the sdk.
Related Issues
Closes #91
Additional Information
Not really